Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): conditionally access globals #99

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix(app): conditionally access globals #99

merged 3 commits into from
Jul 30, 2024

Conversation

ComfortablyCoding
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding commented Jul 28, 2024

Scope

What's changed:

  • Added conditional access for all globals property access. This ensures if directus is not reachable the app still works.

Potential Risks / Drawbacks

  • None

Review Notes / Questions

  • In a future PR we should add defaults where needed to remove the need for conditional access

Fixed: #68

@ComfortablyCoding ComfortablyCoding added the bug Something isn't working label Jul 28, 2024
Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agency-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 6:08pm

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for agency-os ready!

Name Link
🔨 Latest commit bb226d5
🔍 Latest deploy log https://app.netlify.com/sites/agency-os/deploys/66a688975d16db0008510fa6
😎 Deploy Preview https://deploy-preview-99--agency-os.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryantgillespie bryantgillespie merged commit 9abcfec into main Jul 30, 2024
7 of 8 checks passed
@ComfortablyCoding ComfortablyCoding deleted the issue-68-1 branch July 31, 2024 00:04
@ComfortablyCoding ComfortablyCoding mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm i fails
2 participants