Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role requests UI #222

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Role requests UI #222

wants to merge 13 commits into from

Conversation

eguerrant
Copy link
Contributor

@eguerrant eguerrant commented Jan 8, 2025

Adding in Role Requests to the Access UI

In this PR, I:

  • Updated the Role Requests API so that blocked roles aren't shown to blocked owners and are forwarded to Access admins as needed
  • Created a UI for Role Request creation, list, and viewing/response
  • Fixed various bugs I found along the way (including on non-role requests pages)

General Workflow

If you own at least one role, a 'Create a request button' will be shown. You will have the option to choose for which of the roles you own you'd like to make a request, to which non-role group you'd like the role to be added to, membership/ownership, an amount of time for access, and the ability to provide a reason.

Owners or admins should be notified on role request creation.

Owners who are not blocked by group tag constraints can respond to the request. If the owner is blocked, a note will be shown.

If all group owners are blocked, Access admins will need to respond to the request. The request is added to admins' 'Assigned to me' list and a note is shown that all owners are blocked on the request page.

After a decision is made on the request, the requester is notified of the decision.

Screenshot 2025-01-08 at 3 50 58 PM

Screenshot 2025-01-08 at 3 49 35 PM

Screenshot 2025-01-08 at 3 49 56 PM

Regular role request read page:
Screenshot 2025-01-08 at 3 52 03 PM

Viewing role members who will be added if the request is approved:
Screenshot 2025-01-08 at 3 54 42 PM

Blocked owner role request read page:
Screenshot 2025-01-08 at 2 56 49 PM

Admin view all owners blocked request read page:
Screenshot 2025-01-08 at 3 11 32 PM

@eguerrant eguerrant marked this pull request as ready for review January 9, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant