Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] adding deps for kafka + sasl to work #5

Closed
wants to merge 1 commit into from

Conversation

avinashak
Copy link

title. adding necessary flags on deps libs

@avinashak
Copy link
Author

idk why the diffs are showing up like this 💭

@@ -321,7 +321,7 @@ postgres-openssl = { version = "0.5.0", default-features = false, features = ["r
pulsar = { version = "6.3.0", default-features = false, features = ["tokio-runtime", "auth-oauth2", "flate2", "lz4", "snap", "zstd"], optional = true }
rand = { version = "0.8.5", default-features = false, features = ["small_rng"] }
rand_distr = { version = "0.4.3", default-features = false }
rdkafka = { version = "0.35.0", default-features = false, features = ["tokio", "libz", "ssl", "zstd"], optional = true }
rdkafka = { version = "0.35.0", default-features = false, features = ["tokio", "libz", "ssl", "zstd", "sasl", "curl"], optional = true }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the new change

### Currently Patched
The following are patched:
- Fixing GCS Sink error type that allows proper retry handling
- Extremely generous retry logic that functionaly retries everything

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

functionaly is not a recognized word. (unrecognized-spelling)
@@ -0,0 +1,136 @@
diff --git a/src/gcp.rs b/src/gcp.rs
index bfc486f92..148fa9dec 100644

Check warning

Code scanning / check-spelling

Candidate Pattern Warning

Line matches candidate pattern "index (?:[0-9a-z]{7,40},|)[0-9a-z]{7,40}..[0-9a-z]{7,40}" (candidate-pattern)
@@ -0,0 +1,136 @@
diff --git a/src/gcp.rs b/src/gcp.rs
index bfc486f92..148fa9dec 100644

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

bfc is not a recognized word. (unrecognized-spelling)
}
}
diff --git a/src/sinks/util/retries.rs b/src/sinks/util/retries.rs
index 003f1990b..fea5cf5be 100644

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

fea is not a recognized word. (unrecognized-spelling)
@avinashak avinashak closed this Dec 18, 2024
@avinashak avinashak deleted the data/add-sasl-deps branch December 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants