Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize action buttons #8539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SirRichardFrancis
Copy link
Member

@SirRichardFrancis SirRichardFrancis commented Dec 21, 2024

About The Pull Request

Makes sure action buttons are added and removed only when it is actually necessary, not every single Life() tick.

Why It's Good For The Game

Better performance.

Testing

Equipped, dropped, and activated items with action buttons (voidsuit and a flashlight) to see if they work correctly.
Hosted via Dream Daemon, reconnected after equipping voidsuit and a flashlight, observed action buttons being visible on login.

Changelog

🆑
code: Optimized action buttons
/:cl:

@MLGTASTICa
Copy link
Contributor

You need to also hook in to Mob/LogIn and Mob/LogOut else someone reconnects and is missing their action buttons.

@SirRichardFrancis
Copy link
Member Author

Touche.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants