FEATURE: Add early support for aarch64 in dev env #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink
commented
Jan 16, 2024
| @@ -5,7 +5,7 @@ set -e | |||
| export RUSTUP_HOME=/usr/local/rustup | |||
| export CARGO_HOME=/usr/local/cargo | |||
| export PATH=/usr/local/cargo/bin:$PATH | |||
| export RUST_VERSION=1.68.0 | |||
| export RUST_VERSION=1.75.0 | |||
There was a problem hiding this comment.
Had to update to the latest version of rust to be able to compile selenium-manager.
Flink
force-pushed
the
loic-dev-for-aarch64
branch
from
3912952 to
8cd089c
Compare
davidtaylorhq
approved these changes
Jan 29, 2024
This patch adds some new steps to support the aarch64 architecture on Linux. An updated version of Rust is needed to compile the `selenium-manager` binary as it’s not shipped with the `selenium-webdriver` gem yet. In the same vein, Google doesn’t ship an aarch64 version of Chrome yet, so it doesn’t make sense to install even Chromium in the image. We have to rely on Firefox to run the system specs.
Flink
force-pushed
the
loic-dev-for-aarch64
branch
from
8cd089c to
4e16b06
Compare
davidtaylorhq
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new steps to support the aarch64 architecture on Linux.
An updated version of Rust is needed to compile the
selenium-managerbinary as it’s not shipped with theselenium-webdrivergem yet.In the same vein, Google doesn’t ship an aarch64 version of Chrome yet, so it doesn’t make sense to install even Chromium in the image. We have to rely on Firefox to run the system specs.
Related PR: discourse/discourse#25230