Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #73: Preserve normalized output from nested Typed Relation fields inside Paragraphs #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alxp
Copy link

@alxp alxp commented Jun 28, 2024

Resolves Issue #73.

Scenario that this fix addresses:

Create a field structure like this:

Contributor Paragraph

  • Contributor typed relation

Where Contributor Paragraph may have more than one instance.

Before the Field Item List normalizer was looping over Field Items and overwriting them , so only the last one was being printed.

image

Now multiple names show up as expected.

image

Let me know if I can provide any more info.

Copy link

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and confirm this works.

@rosiel
Copy link

rosiel commented Sep 20, 2024

I encountered a bug in this solution.

When the typed relation field is attached directly to the node (e.g. the classic Linked Agent setup) rather than in a paragraph, then the author names are pulled too many times.

Screenshot 2024-09-20 at 11 23 21 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants