Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GeoAPI files #100

Closed
wants to merge 4 commits into from
Closed

Adding GeoAPI files #100

wants to merge 4 commits into from

Conversation

Suyash878
Copy link
Contributor

🎯 [New API] : GeoPlaceAPI #78

Closes #<#78>

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @Suyash878, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

Copy link
Owner

@dishamodi0910 dishamodi0910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suyash878, You are using the already existing API to generate the response. So please add it under Existing API Collection Folder. Also add your entry in README.md file there mentioning a small description about your project. Also don't add any images in commit showing the response. Add those screenshots in the Pull Request.
So, in a glance,

  1. Change folder directory.
  2. Make entry of your API in readme.md file of Existing API Collection folder.
  3. Remove output images from commit.
  4. Insert the images of output in the PULL REQUEST.
  5. Some points are missing in the README.md like information of endpoints, usage, please mention it.

@dishamodi0910 dishamodi0910 added under-review Review PR! changes-requested Changes are needed. labels May 18, 2024
@Suyash878 Suyash878 closed this by deleting the head repository May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Changes are needed. under-review Review PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants