Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

football api added #174

Closed
wants to merge 2 commits into from
Closed

football api added #174

wants to merge 2 commits into from

Conversation

Yashgabani845
Copy link
Contributor

@Yashgabani845 Yashgabani845 commented May 28, 2024

🎯 Title and Issue Number

This is football score API named soccers api
it has many endpoints i have shown implementation of few end points and fetched data and shown here
[Existing API Name] : Football Live Score and Statastics Api #173

Closes #173

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Screenshots of working API data and View

Screenshot (171)
Screenshot (172)

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @Yashgabani845, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@Yashgabani845
Copy link
Contributor Author

@dishamodi0910 please review it
if everything is well,
and make sure you assign me this PR and add labels so that no conflict occure in future
thank you

@Yashgabani845
Copy link
Contributor Author

/gssoc24

@dishamodi0910
Copy link
Owner

@Yashgabani845 There are some points I need to make sure over here :

  1. You don't need to assign PR to yourself, that works only for issues. Once the issue is assigned to you, then whenever you create PR, that would be yours only, nothing sort of assignment is needed for PR.
  2. I observed that recently one of your CRICKET score PR I have merged, this one seems more likely to be like that only, so didn't found more value adding as the purpose matters and both are having more or same kind of purpose of score implementation also the way it's executed is also same for both, so would like to close this PR in order to avoid redundancy in repository.

@dishamodi0910
Copy link
Owner

@Yashgabani845 ,I wanted to reach out and let you know that we have decided to close your pull request.🙇

In case of any issues, you can contact us on Discord.
Thank you! ❣️
Happy Coding! ✨
Will See you soon❣️

@dishamodi0910 dishamodi0910 added wontfix This will not be worked on spam Spammy PR! labels Jun 2, 2024
@Yashgabani845
Copy link
Contributor Author

@dishamodi0910 okay no issue about this PR
and just for calrification i have assigned it beacuse
i asked sanjay sir(project maanger) that PR should be assigned or not then he said it should be
so i did that and then after i self assigned he told me that there is no need of that
sorry of inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spam Spammy PR! wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Existing API Name] : Football Live Score and Statastics Api
2 participants