Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translator api added #180

Merged
merged 2 commits into from
Jun 2, 2024
Merged

translator api added #180

merged 2 commits into from
Jun 2, 2024

Conversation

Yashgabani845
Copy link
Contributor

🎯 Title and Issue Number

[Existing API Name] : Google Translator API #178

Closes #178

Screenshot (188)

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @Yashgabani845, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@Yashgabani845
Copy link
Contributor Author

@dishamodi0910 please review it
if everything is well,
and make sure you assign me this PR and add labels so that no conflict occure in future
thank you

@Yashgabani845
Copy link
Contributor Author

/gssoc24

@dishamodi0910
Copy link
Owner

@Yashgabani845 The PR looks good to me, make sure that from next time whenever you use any external API and create PR, make sure that your clientId or API Key is not present as it would be publicly visible to all, so would suggest you to obfuscate it and mention that in steps in README.md of how they need to create the required API keys.

@dishamodi0910 dishamodi0910 merged commit 78686d1 into dishamodi0910:master Jun 2, 2024
@dishamodi0910
Copy link
Owner

@Yashgabani845 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@dishamodi0910 dishamodi0910 added awesome Merged🎊 Merged PR gssoc New label for GSSOC-24 level2 NEW API/2 EXISTING API/3 BUGS labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome gssoc New label for GSSOC-24 level2 NEW API/2 EXISTING API/3 BUGS Merged🎊 Merged PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Existing API Name] : Google Translator API
2 participants