Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Anime Api #326

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Added Anime Api #326

merged 2 commits into from
Aug 8, 2024

Conversation

ananyag309
Copy link
Contributor

🎯 Title and Issue Number

Added anime fact api

Closes #274

🗒️ Checklist:

  • [y] I have mentioned the issue number in my Pull Request.
  • [y] I have gone through rules of when PR will get merged.
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [y] I have created a helpful and easy to understand README.md
  • [y] I have followed proper file structure.
  • [y] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @ananyag309, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@dishamodi0910
Copy link
Owner

Hey @ananyag309, As you are already using the api from the project maintained by someone else, would want that you move this folder under the already existing api's folder. Also please remove the code portion mentioned in README.md

@dishamodi0910 dishamodi0910 added under-review Review PR! changes-requested Changes are needed. labels Jul 20, 2024
@ananyag309
Copy link
Contributor Author

@dishamodi0910 sure i am making the necessary changes

@dishamodi0910
Copy link
Owner

@ananyag309 ,I wanted to reach out and let you know that we have decided to close your pull request.🙇

In case of any issues, you can contact us on Discord.
Thank you! ❣️
Happy Coding! ✨
Will See you soon❣️

@ananyag309 ananyag309 reopened this Jul 21, 2024
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@ananyag309
Copy link
Contributor Author

@dinxsh thank you
please merge it as 10th is the last date @dishamodi0910

@dinxsh dinxsh merged commit fa4d16c into dishamodi0910:master Aug 8, 2024
@dishamodi0910
Copy link
Owner

@ananyag309 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@ananyag309
Copy link
Contributor Author

@dinxsh @dishamodi0910 please add gssoc and level label too and my name under assignes otherwise the points won't be counted under gssoc please

@ananyag309
Copy link
Contributor Author

@Kritika30032002 @dinxsh @dishamodi0910 please add gssoc and level label too and my name under assignes otherwise the points won't be counted under gssoc please

@ananyag309
Copy link
Contributor Author

@Kritika30032002 ma'am please help me out!!!

@dishamodi0910 dishamodi0910 added gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS and removed under-review Review PR! changes-requested Changes are needed. labels Aug 9, 2024
@dishamodi0910
Copy link
Owner

I hope that works now @ananyag309

@ananyag309
Copy link
Contributor Author

thank you ma'am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New API] : Add Amine image generation API
3 participants