Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Countries API #327

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

abckhush
Copy link
Contributor

🎯 [New API] : Countries and Capitals API #305

Closes #305

image
image
image
image

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @abckhush, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@dishamodi0910
Copy link
Owner

Hey @abckhush, It is great one, it has currently a limitation, that you are providing the hardcoded data, just wanted that if you can keep this in form of endpoint, like a endpoint, from where I can add that data to database, and all the operations of fetching data should happen from db.
Looking forward to hearing from you!

@dishamodi0910 dishamodi0910 added under-review Review PR! changes-requested Changes are needed. labels Jul 20, 2024
@abckhush
Copy link
Contributor Author

@dishamodi0910 like you want a database, in which we can add country data also? Or use the same db file as the endpoint for adding and fetching data?

@abckhush
Copy link
Contributor Author

You can now add, delete, and update the database file now.
@dishamodi0910 Kindly review these changes.

Screenshot 2024-07-27 121138
Screenshot 2024-07-27 134417

@abckhush
Copy link
Contributor Author

@dishamodi0910 Kindly merge this. Only a few days are left.

@abckhush
Copy link
Contributor Author

@dishamodi0910 It's 30th today. Kindly merge this.

@Kritika30032002 Kritika30032002 merged commit 20ed6c4 into dishamodi0910:master Aug 5, 2024
@dishamodi0910
Copy link
Owner

@abckhush We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@Kritika30032002 Kritika30032002 added gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS and removed under-review Review PR! changes-requested Changes are needed. labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New API] : Countries and Capitals API
3 participants