Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default localhost on our uri #1341

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

daddykotex
Copy link
Contributor

@daddykotex daddykotex commented Jan 4, 2024

Fixes #1245

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@daddykotex
Copy link
Contributor Author

tried it and it allows me to revert daddykotex/smithy4s-code-generation#13 successfully
I'll do further testing with regards to the different internal implementation we have to make sure everything still works there as well, then I'll mark as ready to be merged

@kubukoz
Copy link
Member

kubukoz commented Jan 5, 2024

tried it and it allows me to revert daddykotex/smithy4s-code-generation#13 successfully

tbh I wouldn't revert it fully, removing CORS is a security improvement :) but if you mean the resetBaseUri part, absolutely let's kill it.

@daddykotex
Copy link
Contributor Author

yeah, no need to reintroduce cors in that case so I just want to remove the resetBaseUri middleware

@daddykotex daddykotex marked this pull request as ready for review January 8, 2024 14:51
@Baccata Baccata merged commit 58353ab into series/0.19 Jan 9, 2024
11 checks passed
@Baccata Baccata deleted the dfrancoeur/1245-no-localhost branch January 9, 2024 09:25
kubukoz added a commit that referenced this pull request Jan 16, 2024
@kubukoz kubukoz mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants