Improve compatibility with nimskull #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defer` in Nim works at scope level and not function level. By calling `defer` in an `if` like this, the pointer was freed immediately, causing an use-after-free bug, breaking nimph on ARC/ORC. This commit fixes the `defer` declaration, allowing nimph to work on ARC/ORC.
alaviss
force-pushed
the
towards-nimskull
branch
2 times, most recently
from
bda572d to
45f6d41
Compare
The multimap API has been deprecated for quite awhile and nimskull already removed it from tables. This commit switch to Table with seq value as an alternative.
Overloading iterator and proc of the same name is currently buggy on NimSkull. Rename symbolicMatch iterator to symbolicMatches to avoid this issue.
NimSkull has removed the multimap API, and given that Group was not very clear on whether it's a multimap or singular map centric, let's temporary use singular map and convert back as needed.
This release contains fixes for nimskull
alaviss
force-pushed
the
towards-nimskull
branch
from
45f6d41 to
83177fd
Compare
|
Should now work with nimskull >= 0.1.0-dev.21077 Will need some CI to test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
TODO before merge
Notes
Nimble fork to use: https://github.com/alaviss/nimble/tree/nimskull