Fix linear moves #10
Merged
Fix linear moves #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knuton
force-pushed
the
fix-linear-moves
branch
3 times, most recently
from
4df6ac7
to
3b7fa93
Compare
knuton
force-pushed
the
fix-linear-moves
branch
from
3b7fa93
to
0ae55d3
Compare
The implementation incorrectly inverted the direction of movement for both the origin point and element annotation, but it should only be done for the origin point.
|
How did you discover this? Was there an issue on our page? |
knuton
added a commit
to knuton/playos
that referenced
this pull request
Aug 26, 2024
This is vendoring focus-shift from a bugfix PR: dividat/focus-shift#10 Should update reference when bugfix is merged.
I am adding focus-shift to the PlayOS controller, and it caused an issue with the sidebar there. Pressing up or down on a freshly loaded info page jumped to the remote maintenance button, instead of to the sidebar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with linear groups, where expansive items were at a disadvantage.
Due to an implementation error that does not matter much as long as all items have similar size or appear in linear order.
Broken:
linear-stretch-fixed-2024-08-26_16.21.39.mp4
Fixed:
linear-stretch-fixed-2024-08-26_16.18.45.mp4