Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/*env*/ entry in .gitignore file allows to name a virtual environment directory flexibly and unambiguously #510

Closed
wants to merge 1 commit into from

Conversation

erkesado
Copy link
Contributor

/env/ entry in .gitignore file is derived from django-cms repository.
This allows developers a better flexibility in naming a virtual environment directory.
So djangocms-admin-style should also apply it in .gitignore specification.

PS: I'm going to work on an issue in django-admin-style and as a contributor, I want the same flexibility in django-admin-style project too :)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1428c0d) 100.00% compared to head (cd0bf97) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksweb
Copy link
Member

Hi @erkesado - rather than adding more specific development things to gitignore, developers can use local or global gitignore files that exist on their machine outside of the repo.

Give this article a read on how you can do this;
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

This is similar to how django operates;
https://github.com/django/django/blob/main/.gitignore

@marksweb marksweb closed this Jan 23, 2024
@erkesado
Copy link
Contributor Author

@marksweb Got it. Thank you.

@erkesado erkesado deleted the feat/gitignore/_env_ branch January 23, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants