Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update build system #514

Merged
merged 5 commits into from
Jan 29, 2024
Merged

chore: Update build system #514

merged 5 commits into from
Jan 29, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 26, 2024

This PR updates the build system

@erkesando Can you check if you can install from this fix (you can install the fix into your venv using pip install -e git+https://github.com/django-cms/djangocms-admin-style@chore/update-build-system)?

Pending: Update of webpack.config.js.

@fsbraun fsbraun requested a review from vinitkumar January 26, 2024 11:57
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89589a8) 100.00% compared to head (4aa3834) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #514   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun marked this pull request as draft January 26, 2024 12:00
@fsbraun fsbraun marked this pull request as ready for review January 26, 2024 22:21
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tried building the assets using this new build system?

@fsbraun
Copy link
Member Author

fsbraun commented Jan 29, 2024

Sure! Works nicely.

@vinitkumar
Copy link
Member

Sure! Works nicely.

@fsbraun Shouldn't we also commit the built files in the same PR, so is there no diff for them?

@fsbraun
Copy link
Member Author

fsbraun commented Jan 29, 2024

@vinitkumar Fair point!! Just added them. The JS now uses ()=>{} notation. I.e., there is a change.

@vinitkumar vinitkumar merged commit cfc0747 into master Jan 29, 2024
37 checks passed
@vinitkumar vinitkumar deleted the chore/update-build-system branch January 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants