-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update build system #514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 3 3
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Have you tried building the assets using this new build system?
Sure! Works nicely. |
@fsbraun Shouldn't we also commit the built files in the same PR, so is there no diff for them? |
@vinitkumar Fair point!! Just added them. The JS now uses |
This PR updates the build system
@erkesando Can you check if you can install from this fix (you can install the fix into your venv using
pip install -e git+https://github.com/django-cms/djangocms-admin-style@chore/update-build-system
)?Pending: Update of webpack.config.js.