Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SASS/CSS that hid picture upload widget in djangocms-blog #523

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

MacLake
Copy link
Contributor

@MacLake MacLake commented Feb 29, 2024

Don’t hide certain divs in form .flex-container.form-multiline

Don’t hide certain divs in form .flex-container.form-multiline
@fsbraun
Copy link
Member

fsbraun commented Feb 29, 2024

Fixes #522

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7b7e5e5) to head (08d0e86).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Feb 29, 2024

Quick question: The PR includes regenerated fonts. I am not sure what has changed - maybe it's just an effect of rebuilding with more modern versions of the node toolset. @MacLake Can you confirm, icons work as expected?

@fsbraun
Copy link
Member

fsbraun commented Feb 29, 2024

@MacLake Can you bump the version in djangocms_admin_style/__init__.py to 3.3.1? I would like to release this immediately, since it is a severe usability bug.

@MacLake
Copy link
Contributor Author

MacLake commented Feb 29, 2024

I just performed npx gulp icons sass bundle with node 20.11.1 like mentioned in the docs. The icons on the page overview work all fine. I force-reloaded the page on Firefox to be sure that the new files are loaded.

Shall I check anything else? Or should I delete the generated fonts?

I’ve bumped the version to 3.3.1. I wanted to ask anyway if I should do this.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @MacLake !

@fsbraun fsbraun merged commit 2d8a951 into django-cms:master Feb 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants