-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Prepare release 3.1.0 #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The publishing flows need updating, but after that I've setup test & production pypi for trusted publishing
uses: pypa/gh-action-pypi-publish@master | ||
with: | ||
user: __token__ | ||
password: ${{ secrets.PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be the trusted publisher workflow rather than the old token based one;
https://github.com/django-cms/djangocms-snippet/blob/master/.github/workflows/publish-to-live-pypi.yml
uses: pypa/gh-action-pypi-publish@master | ||
with: | ||
user: __token__ | ||
password: ${{ secrets.TEST_PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be the trusted publisher workflow rather than the old token based one;
https://github.com/django-cms/djangocms-snippet/blob/master/.github/workflows/publish-to-test-pypi.yml
@marksweb I've updated the flows accordingly. Essentially, the login info can go. |
It's a bit more than that. |
runs-on: ubuntu-latest | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/djangocms-snippet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to match what the pypi project is (or will be when creating these for new projects)
name: Build and publish Python 🐍 distributions 📦 to pypi | ||
runs-on: ubuntu-latest | ||
environment: | ||
name: pypi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name also needs to match what the publisher has defined, but on the whole I just call it pypi
Right, snippet != style. Sorry. |
Description
This PR bumps the version and updates the changelog.
What's Changed
New Contributors
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.