Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack #235

Merged
merged 2 commits into from
May 21, 2024
Merged

Webpack #235

merged 2 commits into from
May 21, 2024
+7,597 −4

Conversation

jochenklar
Copy link
Member

Add webpack config, assets and minimal react apps

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8232206251

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 64.052%
Totals Coverage Status
Change from base Build 8016830665: 0.07%
Covered Lines: 4834
Relevant Lines: 7547
💛 - Coveralls

@jochenklar jochenklar marked this pull request as ready for review May 21, 2024 09:31
@jochenklar jochenklar changed the base branch from master to dev May 21, 2024 09:31
@jochenklar jochenklar requested review from triole and kimakan May 21, 2024 09:31
@jochenklar
Copy link
Member Author

Hi @kimakan , @triole , my plan is to make several smaller PR into dev, so that we can keep an overview. This one is the basic webpack setup. I would merge it now, but if you have time, have a look.

kimakan
kimakan approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@kimakan kimakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested it again. It worked so far.

@jochenklar jochenklar merged commit a0716ee into dev May 21, 2024
10 checks passed
@jochenklar jochenklar deleted the webpack branch May 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimakan kimakan kimakan approved these changes

@triole triole Awaiting requested review from triole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochenklar @coveralls @kimakan