Update HTTP spec: correct scope.asgi.spec_version
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Aug 8, 2024
| HTTP spec this server understands; one of ``"2.0"``, ``"2.1"``, ``"2.2"`` or | ||
| ``"2.3"``. Optional; if missing assume ``2.0``. | ||
| HTTP spec this server understands; for example: ``"2.0"``, ``"2.1"``, ``"2.2"``, | ||
| etc. Optional; if missing assume ``"2.0"``. |
There was a problem hiding this comment.
Why the etc? It's just those 4 values 👀
Suggested change
| etc. Optional; if missing assume ``"2.0"``. | |
| ``"2.3"``. Optional; if missing assume ``"2.0"``. |
There was a problem hiding this comment.
Can't it also be 2.4 or 2.5 now? It's entirely possible I've misread the spec. if so I'll close this; I agree that if those are the only valid values, this change is unnecessary.
There was a problem hiding this comment.
Yes, the www spec is now up to 2.5, so I think this makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a tiny gap in the ASGI HTTP spec for
scope["asgi"]["spec_version"]- all valid versions are explicitly enumerated, but that list hasn't been updated to include newer versions of the ASGI HTTP spec.This change rewords the spec so the list of versions doesn't need to be updated every time there's a new version of the ASGI HTTP spec. I'd also be happy to just add the newer versions to this list instead, but then someone would also need to remember to update it in the future too.
I tested this by rebuilding the docs locally and viewing the changes in my browser: