Ensure mu4e-compose-pre-hook has access to parent message and compose type #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent message and compose type
milouse
commented
Jun 17, 2024
| @@ -461,7 +461,7 @@ The message is resent as-is, without any editing. See | |||
| "Resend message to address: " mu4e--contacts-set))) | |||
| (let ((msg (mu4e-message-at-point))) | |||
| (with-temp-buffer | |||
| (mu4e--prepare-draft msg) | |||
| (mu4e--prepare-draft 'new msg) ;; Resend as fake new? | |||
There was a problem hiding this comment.
@djcb This is the point I’m the less sure about. Do not hesitate to comment if this is completely wrong.
milouse
commented
Jun 17, 2024
| (setq-local | ||
| mu4e-compose-parent-message parent | ||
| mu4e-compose-type compose-type) | ||
|
|
There was a problem hiding this comment.
I’ve cut this part in 2 block:
- move the cl-assert to the
mu4e--prepare-draftfunction (to keep the semantic of "preparing" stuff, ensuring everything is ok) - move the setq-local statement later in the
mu4e--draftfunction to still benefit from being call inside the target buffer (as now they are buffer-local, andmu4e--prepare-draftis called before the buffer is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR try to fix #2715