Go filesystem implementations refactoring #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
djdv
force-pushed
the
j/cgofuse-refactoring
branch
2 times, most recently
from
115f41b to
5101a8a
Compare
djdv
force-pushed
the
j/cgofuse-refactoring
branch
2 times, most recently
from
4a3a892 to
1dc571e
Compare
djdv
force-pushed
the
j/fs-impl-refactoring
branch
from
74a87e7 to
5c3542e
Compare
djdv
force-pushed
the
j/fs-impl-refactoring
branch
from
957f536 to
c8f7bf5
Compare
djdv
force-pushed
the
j/fs-impl-refactoring
branch
from
c8f7bf5 to
bac3e78
Compare
djdv
commented
May 19, 2023
djdv
commented
Jun 5, 2023
This only worked for canonical IPFS paths, not IPNS.
Standard implies we're supposed to return entries or an error, but never both. Previously, at the tail of a directory, we'd return ents + EOF. Now we follow the same convention as standard `os` and `fstest`.
Standard implies we're supposed to return entries or an error, but never both. Previously, at the tail of a directory, we'd return ents + EOF. Now we follow the same convention as standard `os` and `fstest`.
- Add caching mechanism to IPFS, IPNS, and PinFS - Change constructors for all, specifically how options are handled - Change field parser logic for mount-point file - Various minor bugfixes
PinFS: 104 pointer bytes -> 80 nodeInfo: 56 pointer bytes -> 32
Previously we were peeking the cache to avoid inflating the hit counter in commonly seen sequences like `stat;stat;open`. However, it's not likely to be detrimental / cause unwanted evictions if calls to `stat` update the hit counter for a file. It may actually allow some paths to fall out of cache if they're merely being queried/monitored frequently, which is undesirable.
This was referenced Jun 29, 2023
djdv
force-pushed
the
j/fs-impl-refactoring
branch
from
1eb3315 to
748a288
Compare
|
This was mainly reviewed offline, and tested during the development of #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the various changes made to the Go
fs.FSimplementations we currently have.As well as a new work in progress for IPFS' MFS API, which will be used to handle writable methods in KeyFS+IPNS later.Currently being tested against the IPFS Files API, which itself will likely need its own implementation (later).
Edit: removed from this change set. We'll do writable stuff after the
staging/refactorbranch makes it tomaster.PR meta:
Adds on top of #26 originally derived from #20
Initially targeting
j/cgofuse-refactoring, which should targetstaging/refactorafter that's merged.