Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount cmds WIP #2

Open
wants to merge 1 commit into
base: fs
Choose a base branch
from
Open

mount cmds WIP #2

wants to merge 1 commit into from

Conversation

djdv
Copy link
Owner

@djdv djdv commented Nov 17, 2020

Tries to separate things surrounding the cmds.Command for ipfs daemon --mount and ipfs mount into a unified core package.

Standardizes the parsing and flow of flags and config for both invocations. ipfs daemon simply routes to ipfs mount.Run.
Documentation that may be platform specific is build constrained.

The mount service has been wired up to the node's error channel in daemon.go.
While the existing mount implementation doesn't return anything for us to use, the new implementation is set up to integrate with the node here (on startup and shutdown).

The parameter names between the 2 commands had an inconsistency.
ipfs daemon --mount --mount-ipfs --mount-ipns vs ipfs mount --ipfs-path --ipns-path.
For now, I've prefixed the mount parameters and applied them to daemon so they are the same
(ipfs daemon --mount --mount-ipfs-path --mount-ipns-path)

This will be changed soon though to something likely resembling:
ipfs daemon --mount="val1,val2,val3" and ipfs mount val1 val2 val3
where the values look like this
ipfs mount /fuse/ipfs/path/mnt/ipfs /fuse/ipns/path/mnt/ipns

Most of this is just scaffolding to introduce parts of the new mount implementation packages.

@djdv djdv mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant