Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to separate things surrounding the
cmds.Command
foripfs daemon --mount
andipfs mount
into a unified core package.Standardizes the parsing and flow of flags and config for both invocations.
ipfs daemon
simply routes toipfs mount.Run
.Documentation that may be platform specific is build constrained.
The
mount
service has been wired up to the node's error channel indaemon.go
.While the existing
mount
implementation doesn't return anything for us to use, the new implementation is set up to integrate with the node here (on startup and shutdown).The parameter names between the 2 commands had an inconsistency.
ipfs daemon --mount --mount-ipfs --mount-ipns
vsipfs mount --ipfs-path --ipns-path
.For now, I've prefixed the
mount
parameters and applied them todaemon
so they are the same(
ipfs daemon --mount --mount-ipfs-path --mount-ipns-path
)This will be changed soon though to something likely resembling:
ipfs daemon --mount="val1,val2,val3"
andipfs mount val1 val2 val3
where the values look like this
ipfs mount /fuse/ipfs/path/mnt/ipfs /fuse/ipns/path/mnt/ipns
Most of this is just scaffolding to introduce parts of the new
mount
implementation packages.