Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default recipe and modify default template #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix default recipe and modify default template #11

wants to merge 7 commits into from

Conversation

micmicsuarez
Copy link

Hi @djoos,

I created a pull request and I am very happy to contribute in this project so that I can help others.

Changes made

Re-implemented the service resource of beanstalkd in the default recipe. I got in error after the execution of kitchen verify that /etc/init.d/beanstalkd does not exists. This is the error log:

Error executing action `enable` on resource 'service[beanstalkd]'
           ================================================================================

           Errno::ENOENT
           -------------
           No such file or directory - /etc/init.d/beanstalkd

I modified the defaultbeanstalkd.erb because I got an error status when I executed systemctl status beanstalkd. This is the error log:

[vagrant@default-centos-72 ~]$ systemctl status beanstalkd
● beanstalkd.service - Beanstalkd Fast Workqueue Service
   Loaded: loaded (/usr/lib/systemd/system/beanstalkd.service; enabled; vendor preset: disabled)
   Active: failed (Result: start-limit) since Wed 2016-12-14 16:26:16 UTC; 1min 28s ago
  Process: 12278 ExecStart=/usr/bin/beanstalkd $ADDR $PORT $USER $MAX_JOB_SIZE $BINLOG_DIR $BINLOG_SIZE $BINLOG_FSYNC_PERIOD (code=exited, status=5)

I added flags like -f, -l, -p, and others so that it will work. This is the sample change that I made to default template.

ADDR= -l <% if @opts['l'].nil? %>0.0.0.0<% else %><%= @opts['l'] %><% end %>

I added ChefSpec tests for the beanstalkd default recipe.

Thanks,
Michael

Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Signed-off-by: Michael <micmic.suarez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant