Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cron recipe to setup regular backups #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding cron recipe to setup regular backups #3

wants to merge 3 commits into from

Conversation

brint
Copy link

@brint brint commented Feb 18, 2014

PR Includes:

  • New recipe to run backups with a scheduled cron job (hollandbackup::cron)
  • A couple small changes to README.md formatting

Brint O'Hearn added 2 commits February 18, 2014 17:26
Adding cron dependency

Added cron documentation

Updated docs

doc update

Link fix

Metadata
@djoos
Copy link
Member

djoos commented Feb 19, 2014

Hi @brint,

thanks for the PR! I actually left the CRON-recipe out of the latest version of the cookbook as I thought it would be out of the scope for this cookbook... But if there's a need to get it back in, I don't mind either :-)

Kind regards,
David

@brint
Copy link
Author

brint commented Feb 19, 2014

Hey @djoos,

You can't +1 your own PR can you? :) Thanks for maintaining the cookbook! I do think cron is useful inside the cookbook. It's completely isolated from everything else, so the recipe would have to be called directly to setup cron. It's something we'll be using for sure, and keeps us from having to write and maintain additional site cookbooks.

Let me know what you think!

Brint

@brint
Copy link
Author

brint commented Feb 20, 2014

Added a commit to add RHEL/CentOS support as well.

@djoos
Copy link
Member

djoos commented Jul 21, 2014

Hi @brint,

sorry for the huge delay in getting back to you!

A recent PR (#4) added in CentOS/RHEL support... I'm actually still not 100% sure whether the CRON-support belongs in the cookbook rather than in a wrapper cookbook, hence why it hasn't been merged yet.

Do let me know your thoughts so we can make progress with this PR. Thanks in advance for your feedback!

Kind regards,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants