-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lwrps and recipes with libraries #6
base: master
Are you sure you want to change the base?
Conversation
Hi @djoos ! I would really appreciate it if you could take a look at this and any feedback is welcome! :) |
centos and ubuntu have different default permissions for this file, so they won't match unless we modify the default configuration.
Tests are now passing for Ruby 2.0 and 2.1. 😄 👍 I believe 1.9.3 is no longer supported in Chef 12, but I haven't removed that version from https://www.chef.io/blog/2014/11/25/ruby-1-9-3-eol-and-chef-12/ |
Hi @marcoamorales, sorry for the delay in getting back to you. Would you mind grouping the providers and resources into separate directories ~ newrelic-cookbooks' LWRPs. Just for consistency sake across our cookbooks... Thanks in advance for your feedback! Kind regards, |
Oh, and: you can drop 1.9.3 from Thanks in advance! |
Hi @marcoamorales, I spoke to @niven01 last night at the DevOps meetup. He also mentioned your HWRP-approach in this PR. I let him know I'm not 100% too up-to-speed with HWRPs, but that I'm happy to discuss the reasons behind your approach further. Thanks in advance for reaching out! Kind regards, |
Let me know what you think and I'm open to any feedback! :)
Take a look at the fixture cookbook to see how the cookbook would be consumed.
Ex: