services hash to yaml generate garbage #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to_yaml has generated garbage and make the newrelic plugin configuration completely invalid. The fix is to convert Chef's Hash to ruby hash , then JSON then to yaml. Without the JSON part still causing garbage in the configuration.
|
@djoos any thoughts on this? fixes the issue for me... |
|
fixes the problem for me also |
|
This snippet of code has always felt "dirty" to me and hurting to the eye - unfortunately this doesn't improve things :-) Having said that, I am happy to merge this inso it does what it is expected to do. Is it right to understand that on Chef 10, 11, 13 & 14 the original code does the trick, but there's an issue in Chef 12? Thanks in advance for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_yaml has generated garbage and make the newrelic plugin configuration completely invalid. The fix is to convert Chef's Hash to ruby hash , then JSON then to yaml. Without the JSON part still causing garbage in the configuration.
This problem seems happened with Chef 12. Here is a similar case with the to_yaml. (http://lists.opscode.com/sympa/arc/chef/2014-02/msg00054.html)