Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons #472

Merged
merged 83 commits into from
May 22, 2021
Merged

New Icons #472

merged 83 commits into from
May 22, 2021

Conversation

baitmooth
Copy link
Contributor

@baitmooth baitmooth commented Apr 26, 2021

_ _ _ _ _
actual antennapod antimine autotools biglybt
birthdaydroid boxcryptor brackeyside changelog circuittrainer
conv6ations cronograma cuberite drastic filmstaden
financemanager gardine gpstest helm helmsync
hendroid iss-detektor kid3 librespeed look4sat moneymanagerex
noice oandbackupx podcastaddict portauthority potatoprojectnotes
railplanner ruler secusoshoppinglist shuttle simplekeyboard
sknetrafiken skymap smartpack solitairecg spacelaunchnow
steamchat sweb terminalemulator trafictransportsparisiens units
ynab

collection

@baitmooth baitmooth mentioned this pull request May 18, 2021
@dkanada
Copy link
Owner

dkanada commented May 18, 2021

Some general thoughts about the current icons are below. Mostly about making them simpler and more uniform, the general designs look fine to me.

  • playing card icon should be a single rectangular card for simplicity
  • the big F icon doesn't match the other circle sizes
  • shuttle icon looks too complicated with that folded middle section (can simplify without removing the fold)
  • simple steam icon should already exist and should be used for the steam chat icon
  • MyBoy and the ISS icon are too complicated but I have no clue how to make them simpler
  • punch out the circle in the spaceship icon
  • unwrap the inner objects in the files and Cronograma icons (the cronograma icon can remove the border circle for example)

cronograma: removed outer circle
filmstaden: fixed size
myboy: drastic simplified
shuttle: simplified fold
solitiarecg: reduced number of cards to one, resize
spacelaunchnow: changed window
steamchat: used simple steamlogo
@baitmooth
Copy link
Contributor Author

baitmooth commented May 18, 2021

Thanks for ideas and hints.

  • playing card icon should be a single rectangular card for simplicity

  • the big F icon doesn't match the other circle sizes

  • shuttle icon looks too complicated with that folded middle section (can simplify without removing the fold)

  • simple steam icon should already exist and should be used for the steam chat icon

  • MyBoy icon are too complicated

  • tried a drastic version

  • ISS icon are too complicated

  • punch out the circle in the spaceship icon

  • unwrap the inner objects in the files and Cronograma icons (the cronograma icon can remove the border circle for example)

  • uncircled the cronograma icon, and will see what can be unwrapped next.

@dkanada
Copy link
Owner

dkanada commented May 18, 2021

Another quick mention, I would use an existing settings icon for the AutoTools icon, and figure out a way to increase the outline for the wrench tool. It's too thin right now and won't show up on low DPI screens.

@baitmooth
Copy link
Contributor Author

Another quick mention, I would use an existing settings icon for the AutoTools icon, and figure out a way to increase the outline for the wrench tool. It's too thin right now and won't show up on low DPI screens.

Ok, thanks for the hint. I will try this. I will also redo Rail planner and Helm Sync which are similar with thin lines.

baitmooth added 4 commits May 19, 2021 00:49
- autotools to make the wrench more visible
- helmsync for simplicity
- railplanner made the train more solid
- solitairecg changed hearts for spades
new (svg & appfilter):
BirthDayDroid
Changelog
Notes
OAndBackupX
SmartPack

updated (appfilter):
Gestion des Ports
Open Food Facts
changed shoppinglist to shopping-list to prevent conflict
@baitmooth
Copy link
Contributor Author

There are now two apps named 'Shopping List' they seem to be different apps which may be installed alongside. I renamed the one from secuso. And the question is a little bit about naming... are dashes allowed, like 'shopping-list'? Would an name like 'secusoshoppinglist' be better?

@dkanada
Copy link
Owner

dkanada commented May 20, 2021

I don't believe dashes are allowed so secusoshoppinglist would be best.

shopping-list -> secusoshoppinglist
iss-detektor -> issdetektor
@baitmooth
Copy link
Contributor Author

I don't believe dashes are allowed so secusoshoppinglist would be best.

Done.

@dkanada
Copy link
Owner

dkanada commented May 21, 2021

Wow you are really going through a lot of the requests 😄 I have a few comments, but at this point all of the icons can be merged, I'm just commenting on things that could be improved.

  • HelmSync looks a bit larger than the other circles
  • CircuitTrainer could maybe utilize one of the existing clock or person icons to better match the rest of the pack
  • BoxCryptor might look good with less parts and larger gaps between them (maybe a lock icon somewhere)
  • BiglyBT could somehow be simplified (the inner left curve also doesn't look entirely parallel)

@dkanada
Copy link
Owner

dkanada commented May 21, 2021

If you'd rather merge this as is though, I will be sure this gets in the next release.

@baitmooth
Copy link
Contributor Author

Wow you are really going through a lot of the requests smile I have a few comments, but at this point all of the icons can be merged, I'm just commenting on things that could be improved.

It's a fun way to spend time ;) while finally gaining inkscape-skills.

* HelmSync looks a bit larger than the other circles

I'm not completly happy with Helm/HelmSync but i have not figured out how to really improve it. It only looks bigger, and it is actually a few picopixel smaller.

* CircuitTrainer could maybe utilize one of the existing clock or person icons to better match  the rest of the pack

* BoxCryptor might look good with less parts and larger gaps between them (maybe a lock icon somewhere)

* BiglyBT could somehow be simplified (the inner left curve also doesn't look entirely parallel)

Good ideas, thanks for that. I will put it in my tasklist for rework.

If you'd rather merge this as is though, I will be sure this gets in the next release.

I have no clear preference about the time of merge. Would be happy to see some soon, but no hurry about that. I take this as a moment for kind of feature freeze and looking at the issues.

baitmooth added 2 commits May 21, 2021 19:12
biglybt - was not very symmetric
boxcryptor - too small segments
circuittrainer - changed that running person
changed the clock
@dkanada dkanada merged commit c37b213 into dkanada:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants