-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(env): change the environment to be /usr/bin/env bash #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ This PR fixes following deprecations:
Total deprecations: 110 Total warnings: 4 Build statistics: statistics (-before, +after)
client size=1048544 bin/dcd-client
server size=3085624 bin/dcd-server
rough build time=77s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.72
-DCD run_tests.sh Maximum resident set size (kbytes): 46096
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.76
+DCD run_tests.sh Maximum resident set size (kbytes): 45332
short requests: (230x)
- min request time = 0.009ms
- 10th percentile = 0.135ms
- median time = 0.493ms
- 90th percentile = 0.794ms
- max request time = 1.584ms
+ min request time = 0.008ms
+ 10th percentile = 0.148ms
+ median time = 0.461ms
+ 90th percentile = 0.807ms
+ max request time = 1.789ms
long requests over 10ms: (51x)
- min request time = 19.067ms
- 10th percentile = 19.966ms
- median time = 21.050ms
- 90th percentile = 24.058ms
- max request time = 30.784ms
+ min request time = 18.607ms
+ 10th percentile = 19.690ms
+ median time = 21.397ms
+ 90th percentile = 25.113ms
+ max request time = 31.488ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
- 78384128 843 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
+ 78109696 843 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371616 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628 Full build output
|
vushu
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the places using
/bin/bash
to/usr/bin/env bash
. This is important for OS'es which do not have bash located here such as NixOS.