-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new request to get inlay hints #762
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ This PR fixes following deprecations:
Total deprecations: 110 Total warnings: 4 Build statistics: statistics (-before, +after)
-client size=1048544 bin/dcd-client
-server size=3085624 bin/dcd-server
-rough build time=65s
+client size=1052640 bin/dcd-client
+server size=3085760 bin/dcd-server
+rough build time=66s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.35
-DCD run_tests.sh Maximum resident set size (kbytes): 43588
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.39
+DCD run_tests.sh Maximum resident set size (kbytes): 45472
short requests: (230x)
- min request time = 0.012ms
- 10th percentile = 0.145ms
- median time = 0.404ms
- 90th percentile = 0.725ms
- max request time = 3.425ms
+ min request time = 0.010ms
+ 10th percentile = 0.156ms
+ median time = 0.415ms
+ 90th percentile = 0.759ms
+ max request time = 2.875ms
long requests over 10ms: (51x)
- min request time = 12.401ms
- 10th percentile = 13.550ms
- median time = 16.581ms
- 90th percentile = 22.116ms
- max request time = 25.597ms
+ min request time = 12.733ms
+ 10th percentile = 13.740ms
+ median time = 16.550ms
+ 90th percentile = 23.471ms
+ max request time = 24.806ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
78109696 843 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371616 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628 Full build output
|
WebFreak001
requested changes
Nov 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test pls, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning, for now just aliases, i tried with function arguments, but it require more work, see #761
I think this has potential