-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getSymbolsForCompletion raise exception #773
Conversation
should first check if the range `beforeTokens` is empty.
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1052480 bin/dcd-client
server size=3102008 bin/dcd-server
-rough build time=59s
+rough build time=60s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.83
-DCD run_tests.sh Maximum resident set size (kbytes): 35832
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.97
+DCD run_tests.sh Maximum resident set size (kbytes): 35408
short requests: (240x)
min request time = 0.007ms
- 10th percentile = 0.140ms
- median time = 0.353ms
- 90th percentile = 0.635ms
- max request time = 1.482ms
+ 10th percentile = 0.174ms
+ median time = 0.373ms
+ 90th percentile = 0.613ms
+ max request time = 1.478ms
long requests over 10ms: (51x)
- min request time = 11.496ms
- 10th percentile = 12.641ms
- median time = 13.835ms
- 90th percentile = 15.407ms
- max request time = 21.779ms
+ min request time = 12.616ms
+ 10th percentile = 13.870ms
+ median time = 15.126ms
+ 90th percentile = 16.835ms
+ max request time = 22.653ms
top 5 GC sources in server: Full build output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have a code sample where it happened before? Adding it as a test case to the tests folder would be quite appreciated
This was encountered by chance, and I cannot consistently reproduce the bug. I'm unclear about the details. |
ok let's just add it as is then |
should first check if the range
beforeTokens
is empty.