tests/extra/tc_ufcs_all_kinds: support gdc #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the usage of `-run` which isn't supported by gdc and only pass `-verrors=0` to dmd and ldc2 since gdc doesn't support the flag and, by default, all errors are printed. Change the format in which errors are printed to keep it consistent across all the three major compilers (a style that they all support is the gnu style) and make the matching code in generate_tests.d more readable by using a regex. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
|
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1052480 bin/dcd-client
server size=3102008 bin/dcd-server
-rough build time=61s
+rough build time=60s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.89
-DCD run_tests.sh Maximum resident set size (kbytes): 39568
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.69
+DCD run_tests.sh Maximum resident set size (kbytes): 35700
short requests: (240x)
- min request time = 0.010ms
- 10th percentile = 0.135ms
- median time = 0.373ms
- 90th percentile = 0.613ms
- max request time = 1.562ms
+ min request time = 0.012ms
+ 10th percentile = 0.146ms
+ median time = 0.363ms
+ 90th percentile = 0.633ms
+ max request time = 1.448ms
long requests over 10ms: (51x)
- min request time = 12.956ms
- 10th percentile = 13.621ms
- median time = 15.001ms
- 90th percentile = 16.259ms
- max request time = 21.103ms
+ min request time = 12.576ms
+ 10th percentile = 13.996ms
+ median time = 15.354ms
+ 90th percentile = 16.602ms
+ max request time = 22.645ms
top 5 GC sources in server:Full build output |
|
can you add the test to github actions? |
It would be my first time touching CI but I can certainly try. It just needs to be one compilation + tests with gdc or do you want as many as for dmd and ldc? |
|
you can look at D-Scanner to see how we use GDC there: https://github.com/dlang-community/D-Scanner/blob/master/.github/workflows/default.yml just the latest GDC version on supported OSes (probably only linux) is enough as compiler. Keep the min/max dub dependency version check though |
|
Gotcha, looks understandable enough. I won't be able to do it today or tomorrow however due to time constraints so, as long as you don't mind, it will take me a while before the change. |
|
it'd probably be easier to just add it to setup-dlang than having another special case here |
|
Don't mind the commit, just pushed to the wrong branch. |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of
-runwhich isn't supported by gdc and only pass-verrors=0to dmd and ldc2 since gdc doesn't support the flag and, by default, all errors are printed.Change the format in which errors are printed to keep it consistent across all the three major compilers (a style that they all support is the gnu style) and make the matching code in generate_tests.d more readable by using a regex.