-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DCD as lib interface #777
Draft
ryuukk
wants to merge
1
commit into
dlang-community:master
Choose a base branch
from
ryuukk:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1079792 bin/dcd-client
-server size=3108616 bin/dcd-server
-rough build time=60s
+server size=
+rough build time=51s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.88
-DCD run_tests.sh Maximum resident set size (kbytes): 37244
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:00.00
+DCD run_tests.sh Maximum resident set size (kbytes): 768
-short requests: (240x)
- min request time = 0.012ms
- 10th percentile = 0.152ms
- median time = 0.363ms
- 90th percentile = 0.620ms
- max request time = 1.508ms
-long requests over 10ms: (51x)
- min request time = 11.632ms
- 10th percentile = 12.840ms
- median time = 14.521ms
- 90th percentile = 16.329ms
- max request time = 23.446ms
top 5 GC sources in server: Full build output
|
Alternative approach to this:
https://github.com/Pure-D/serve-d/blob/master/dcd/source/served/dcd/client.d
…On Wed, 10 Jul 2024, 21:26 ryuukk, ***@***.***> wrote:
Tests fail because i have introduced a new field to DSymbol: location_end,
to keep track of scopes, making it easier to implement sticky scroll /
outline features
image.png (view on web)
<https://github.com/dlang-community/DCD/assets/44361234/5178d85d-9127-4ef3-8c20-ecac5a04fc21>
—
Reply to this email directly, view it on GitHub
<#777 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHSL46XRUBPEOY3FJAVTUTZLT427AVCNFSM6AAAAABKUPWD36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGAYDCOJRG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
No this is just bad, you still need to spawn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using DCD as a library, useful for making tooling
I have a proof of concept of a simple LSP that uses DCD as a library, making its lifecycle much simpler, no need to spawn/track bunch of processes
This is just a draft for now, i'm seeking feedback/opinions