-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(errors): make verrors=context global and update test outputs #17085
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @royalpinto007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17085" |
17c012d
to
467933c
Compare
467933c
to
e9d3051
Compare
0081e4e
to
e3d8e37
Compare
Was it decided somewhere that this should become the default? I prefer the current default, and don't like how this makes the test suite harder to maintain. |
61d3006
to
18a28ac
Compare
Don't think so, but we are one of not many languages still not doing the squiggle by default. That debate aside, the last time I think someone (hatf0 I think) tried to turn it a bunch of things blew up so I asked @royalpinto007 to look into just to see how things were going on that front. |
Signed-off-by: royalpinto007 <royalpinto007@gmail.com>
18a28ac
to
f079c7c
Compare
I like this PR With the code example, i know exactly what's wrong without having to decipher a lengthily message I use Zig a lot and this is so much better |
WIP - Make
verror=context
usage global and update related test files accordingly.