-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always update the install script #302
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit too blunt and also unexpected for users. I'd be in favor of some regular (weekly) etag based check.
Also auto-updates should only be done if they're verifyable (gpg available).
Another point, atm. we have to be backwards compatible with the server layouts, but we shouldn't negligently drop backwards compatibility just b/c of auto-updates.
Where can we store the etag?
Fair enough. |
I think this is fine to do when installing a new version. Currently "install" (with a specific version) does nothing if that version compiler is already installed, and I think that should continue not performing any network activity. You could also make use of the |
@wilzbach, is it safe to assume that you no longer plan on pursuing this further? |
If we go with this, imho we should reopen #274 (config file) and allow people to opt-out of this.
There are certainly use cases in which always updating the installer can be annoying, especially if you use the install script with an already installed compiler this will add a few seconds extra to every activation.