Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] GHA: Switch from macos-latest (currently *arm64* macOS 14) to macOS 12 #576

Merged
merged 1 commit into from
May 10, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented May 9, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@kinke
Copy link
Contributor Author

kinke commented May 10, 2024

Okay, macos-12 works; I'll try macos-13 shortly too.

@kinke
Copy link
Contributor Author

kinke commented May 10, 2024

Nope, same problem (Mac linker assertion) on macOS 13 x86_64. I guess it's Xcode v15 then, as both macos-{13,14} images currently default to v15.0.1, while macos-12 defaults to v14.2.

https://github.com/dlang/installer/actions/runs/9025225631/job/24800683396?pr=576

@kinke kinke marked this pull request as ready for review May 10, 2024 00:30
@ibuclaw ibuclaw merged commit 6174785 into dlang:stable May 10, 2024
32 checks passed
@ibuclaw
Copy link
Member

ibuclaw commented May 10, 2024

Ok, I'll merge this as-is for now as I see everything is green. Investigating Xcode 15 can then be done separately.

@kinke kinke deleted the gha_macos branch May 10, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants