Fix D-Scanner linting issues

[Vladiwostok]

This PR contains only code format changes.

There are a couple of linting issues that are now detected with the dmd-as-a-lib D-Scanner.

• UndocumentedDeclarationCheck => detects undocumented public declarations; the fix consists of changing the normal comment chars to DDoc comment chars and documenting the unit test;
• IfConstraintsIndentCheck => detects static ifs that are not on separate lines nor to they match the template's column indentation; the fix consists of moving the if conditions on separate lines and aligning them with the template declaration.

[dlang-bot]

Thanks for your pull request and interest in making D better, @Vladiwostok! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9070"

[RazvanN7]

As I understand the check should limit itself to highlighting instances of unaligned if constraints. We should leave it to the user to then split the constraints as he/she sees fit.

[Vladiwostok]

As I understand the check should limit itself to highlighting instances of unaligned if constraints. We should leave it to the user to then split the constraints as he/she sees fit.

I see. I just saw those conditions split on multiple lines and thought it would be easier to read if they can fit in a single line. Will revert those kind of changes

[CyberShadow]

UndocumentedDeclarationCheck => detects undocumented public declarations; the fix consists of changing the normal comment chars to DDoc comment chars and documenting the unit test;

Careful, there are many cases where a declaration is not intended for public use but must be public for technical reasons. I think a way to override this check would be more useful.

[Vladiwostok]

UndocumentedDeclarationCheck => detects undocumented public declarations; the fix consists of changing the normal comment chars to DDoc comment chars and documenting the unit test;

Careful, there are many cases where a declaration is not intended for public use but must be public for technical reasons. I think a way to override this check would be more useful.

I agree. We can create an issue in D-Scanner to implement @nolint exception for UndocumentedDeclarationCheck.

[thewilsonator]

generated/linux/debug/64/publictests/std_random.d(2287): Error: template instance `isForwardRange!(typeof(gen))` template `isForwardRange` is not defined
generated/linux/debug/64/publictests/std_random.d(2287):        while evaluating: `static assert(isForwardRange!(typeof(gen)))`
generated/linux/debug/64/publictests/std_random.d(2296): Error: undefined identifier `meta` in package `std`, perhaps add `static import std.meta;`
generated/linux/debug/64/publictests/std_random.d(2350): Error: undefined identifier `meta` in package `std`, perhaps add `static import std.meta;`

[Vladiwostok]

UndocumentedDeclarationCheck => detects undocumented public declarations; the fix consists of changing the normal comment chars to DDoc comment chars and documenting the unit test;

Careful, there are many cases where a declaration is not intended for public use but must be public for technical reasons. I think a way to override this check would be more useful.

I agree. We can create an issue in D-Scanner to implement @nolint exception for UndocumentedDeclarationCheck.

Created issue: Dlang-UPB/D-scanner#165