Prevent pdfalto subprocess call failing due input filename #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spaces + ampersands in PDF source url were seen to cause issues. PDF saved with safe name and source saved in txt file alongside for troubleshooting.
Resulting output will now be:
details.txt
isn't necessary and only added to aid debugging/troubleshooting aswork-folder
is randomly generated.whereas previously it would be a single PDF, named using final part of URL
If the final path contained
' '
or&
the subprocess call to/usr/bin/pdfalto
would fail.Unrelated to above fix but also bumped LocalStack image used for local testing.