Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics docs and disabling #1186

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Metrics docs and disabling #1186

merged 4 commits into from
Sep 24, 2024

Conversation

malteish
Copy link
Collaborator

@malteish malteish commented Sep 24, 2024

add some docs

Manually implement the disabling of metrics collection. While the original idea that redis will expire data immediately if retention is set to 0 is correct, it has some drawbacks:

  • not explicit
  • performs unnecessary write operations
  • generates logs
    -> better to manually prevent the writes in the first place.

@AlexNi245 AlexNi245 merged commit fa38ea3 into develop Sep 24, 2024
17 checks passed
@AlexNi245 AlexNi245 deleted the metricsDocsAndDisabling branch September 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants