Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing the i18l namespace in a few places. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cromulus
Copy link

@cromulus cromulus commented Feb 2, 2015

the plugin was using the "vagrant_sync" namespace for errors in translations.

@dmatora
Copy link
Owner

dmatora commented Feb 2, 2015

what issue does it solve and how solution can be tested?

@cromulus
Copy link
Author

cromulus commented Feb 2, 2015

First attempt at using the plugin and this error appeared:

Bringing machine 'default' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Unison:
* translation missing: en.vagrant_sync.config.host_folder_required
* translation missing: en.vagrant_sync.config.guest_folder_required

With the change in the translation namespace, we should see helpful errors about the configuration, rather than translation missing errors. A bit more user friendly.

@dmatora
Copy link
Owner

dmatora commented Feb 2, 2015

Ok, looks like this is supposed to resolve http://mrdavidlaing/vagrant-unison/#7

@dmatora
Copy link
Owner

dmatora commented Feb 2, 2015

can you update version.rb?

@cromulus
Copy link
Author

cromulus commented Feb 2, 2015

Sure. Away from my computer for the next few hours...

sent on the move

On Feb 2, 2015 4:48 PM, "dmatora" notifications@github.com wrote:

can you update version?


Reply to this email directly or view it on GitHub
#1 (comment).

@dmatora
Copy link
Owner

dmatora commented Feb 2, 2015

Doesn't look like it's solving the issue. Getting

There are errors in the configuration of this machine.
Please fix the following errors and try again:

Unison:
* translation missing: en.vagrant_unison.config.host_folder_required
* translation missing: en.vagrant_unison.config.guest_folder_required

@dmatora
Copy link
Owner

dmatora commented Feb 8, 2015

Any news?

@cromulus
Copy link
Author

Been underwater at work past few weeks. Should have a second or two in the
next few days to take a look and fix this.

sent on the move

On Feb 8, 2015 6:37 AM, "dmatora" notifications@github.com wrote:

Any news?


Reply to this email directly or view it on GitHub
#1 (comment).

@killua99
Copy link

Any idea hot to apply an hotfix? I need to try this unison, cause is quite annoying only host to guest and not birections

@dmatora
Copy link
Owner

dmatora commented Feb 26, 2015

you don't really need this fix to make plugin working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants