Allow using Vagrant without vagrant-unison #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regular user so it'll resolve correctly
sync, change config args to also start with unison
and exit, fix a bug where trying to rm ~/.unison with sudo resolves to the wrong path, fix a bug where Listener.listen? is from an old version of the listen gem which was too old to be resolved along with the vagrant gem
itself, this can mess up e.g. a docker container with that directory mounted
well, stuff in .git/ is often the thing that gets out of sync.
Restart sync polling if the process crashes
Add a background thread to kill vagrant when memory use gets high
Allow configuration of ssh user, host and port
This adds info about possible error due to ocaml version differences. Also clarifies installation instructions
Make the Restart memory limit a config variable
Update README.md
Add perms arg as optional argument. Update readme
Fix ssh authorization issue.
So it interoperates with the Ubuntu versions. The zipfile includes a `unison-fsmonitor.exe` which I haven't looked at -- of use?
Update name of ubuntu unison package
Update Windows binary to 2.48
Each ignore pattern is added as a seperate ignore argument to the unison command.
Vagrant uses this class method to print a description of your command when you run `vagrant` without any sub-commands. This improves the usability of this plugin.
This commit also adjusts our commands to print unison's exit status, whenever it exits.
When enabled, this config option turns off using the Vagrant-supplied identity file, so that unison's ssh command will use the system's ssh-agent or ssh config. One reason you might want to do this is to use a PKCS11 hardware token to connect to your vagrant machine. Vagrant itself is lagging on support for this feature; at Airbnb we use a monkey-patch.
add --push, --pull, --force-push, --force-pull options to all vagrant-unison2 commands. These flags allow setting the unison options `-prefer` and `-force` to prefer or force changes from a specific root. --push or --force-push prefers/forces the unison root on the local machine. --pull or --force-pull prefers/forces the unison root on the Vagrant remote machine. improve the help output of all commands to read clearly if called like `vagrant unison-sync-interact --help`
Notify upstream of Airbnb changes
We removed the unison-sync command and with it the dependency on ruby `listen` gem because using unison's fs polling works a lot better, at least on OSX Hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous behavior, simply having this plugin installed requires any Vagrant VM you want to run to set up a unison sync.
This PR removes that restriction, so if you set one of host or guest but not both it will give a validation error, but if you don't want any unison-synced directory there is no error.