Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] alternate hreflang #97

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

jwundrak
Copy link

Related to #17

Here is a first implementation of hreflang in Sitemap like documented here: https://support.google.com/webmasters/answer/2620865?hl=en

Because I don't use tt_news, I only implemented for pages (and my custom extension records).
The implementation works for me in different modes. Feel free, to comment. I don't know, if the implementation can more elegenat.

Notice: I introduced a new abstract class AbstractExtendedSitemapRenderer to keep backwards-compatibility for other record types.

@jwundrak jwundrak force-pushed the feature/alternate-hreflang branch from 33d7d14 to f65ded1 Compare May 14, 2018 10:49
@TomasJerrySebo
Copy link

This is a nice feature and it would be more than welcomed, will it merged?

@jwundrak jwundrak force-pushed the feature/alternate-hreflang branch from f65ded1 to 96dfdd7 Compare May 22, 2018 09:31
@jwundrak
Copy link
Author

I wrote last week an email to @dmitryd , but he is currently very busy and has no time, to look at this request:

Yes, the extension is still supported but I do not plan updates soon. I am quite busy at my daily job and nobody from my paying clients requested this functionality. Currently I have no time for work on my free extensions. So I cannot tell when this will be integrated.

The best thing, to complete the pull request by the community, if more people want's this feature. Then it should be more easier for dmitry to review the request. So please give me feedback and suggestions at my branch.

I commit some performance optimatimations, but tt_news implementation is still missing

@jwundrak jwundrak force-pushed the feature/alternate-hreflang branch from 96dfdd7 to f881365 Compare May 22, 2018 12:00
@dmitryd
Copy link
Owner

dmitryd commented Feb 3, 2019

The change is unnecessarily large and contains changes that are not related to the ticket in question. I may reuse some parts but I will not be able to use it as whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants