Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and modernize release-artifacts.py #10818

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Clean up and modernize release-artifacts.py #10818

merged 1 commit into from
Oct 11, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Sep 12, 2024 •
edited
Loading

Continue #10809

  • Use precise terminologies
  • Use pathlib instead of os.path
  • Remove unused variables and arguments

@hcho3 hcho3 merged commit 0c32881 into dmlc:master Oct 11, 2024
26 of 30 checks passed
@hcho3 hcho3 deleted the modernize_artifact_script branch October 11, 2024 23:37
@hcho3 hcho3 mentioned this pull request Oct 11, 2024
Closed
10 tasks
trivialfis pushed a commit to trivialfis/xgboost that referenced this pull request Oct 22, 2024
@hcho3 @trivialfis
[BP] Clean up and modernize release-artifacts.py (dmlc#10818)
2aae603
trivialfis added a commit that referenced this pull request Oct 22, 2024
@trivialfis @hcho3
[BP] Clean up and modernize release-artifacts.py (#10818) (#10919)
346c1f9 
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis