[coll] Avoid all-to-all connection. #10840
Draft
+244
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a fixed tree topo for broadcast by always sending the data to the 0th node. XGBoost always broadcast with 0th node as root anyway. - Reduce the amount of connections.
trivialfis
commented
Sep 23, 2024
| @@ -155,6 +157,7 @@ Result RabitTracker::Bootstrap(std::vector<WorkerProxy>* p_workers) { | |||
| for (auto const& w : workers) { | |||
| worker_error_handles_.emplace_back(w.Host(), w.ErrorPort()); | |||
| } | |||
| LOG(CONSOLE) << "[tracker]: Bootstrap " << workers.size() << " workers."; | |||
There was a problem hiding this comment.
Will turn this into a debug log controlled by the verbosity parameter once we have all tests done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XGBoost always broadcast with 0th node as root anyway.
n_workersas a hint to the listen call.todo: