Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMN 1.4 - 1153-boxed-some #604

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

StrayAlien
Copy link
Contributor

No description provided.

@StrayAlien StrayAlien changed the title DMN 1.4 - 1152-boxed-for DMN 1.4 - 1153-boxed-some Jun 24, 2023
@opatrascoiu
Copy link
Contributor

opatrascoiu commented Jul 24, 2023

@StrayAlien I think test 007 is debatable.

The intention is to test when the input is an empty list: <description>Will return false for empty list</description>

However, decision007 is not well-formed, the satisfies condition is not a boolean expression: <satisfies><literalExpression><text>"not a boolean"</text></literalExpression></satisfies>

I suggest replacing it with <satisfies><literalExpression><text>true</text></literalExpression></satisfies>

Apart from that, the tests look good to me.

Thank you again !!

@SimonRinguette
Copy link
Contributor

Same comments I made here: #605 (comment) applies to this one

@SimonRinguette
Copy link
Contributor

RTF issue: https://issues.omg.org/issues/INBOX-1770

… 7 to reflect Octavian comment re 'two things wrong in the same test'
@StrayAlien
Copy link
Contributor Author

commented out test 3/4 for undecided list coercion. Also changed test 7 to reflect @opatrascoiu comment re 'two things wrong in the same test'

@baldimir baldimir merged commit 3e6bc9b into dmn-tck:master Nov 16, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants