Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMN 1.5 1155-feel-range #620

Closed

Conversation

SimonRinguette
Copy link
Contributor

Additional test coverage around ranges

@StrayAlien
Copy link
Contributor

@SimonRinguette - range function is 1.5, not 1.4?

@SimonRinguette SimonRinguette changed the title DMN 1.4 1155-feel-range DMN 1.5 1155-feel-range Oct 19, 2023
@SimonRinguette
Copy link
Contributor Author

Moved to DMN 1.5 since we are using the range function in the test case

@StrayAlien
Copy link
Contributor

StrayAlien commented Apr 18, 2024

Simon, the new grammar 66 in the 1.5 beta spec seems not to permit unary ranges as string ranges. From what I can see, (please correct me if wrong), but, all range literals must have an range start, a '..' and a range end. In some circumstances an opening or close endpoint may be omitted, but the unary style of < 10 is not permitted as a range literal.

AFAICT, a number of these test are using unary ranges as literals.

I kind missed this PR and have done a separate effort and suite of tests to test range literals, perhaps let's discuss at the meeting.

@opatrascoiu
Copy link
Contributor

There are 2 PRs that cover the range function with different file names. I suggest we drop one and include tests in the other.

@SimonRinguette
Copy link
Contributor Author

Closing this PR, you are right that there is no <10. I realised that when looking at Greg's PR. I had not double checked the test cases, they were prepared by someone on my team. we should use the other test cases for ranges.

@SimonRinguette SimonRinguette deleted the dmn-1-4-1155-feel-range branch May 30, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants