Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM BAMOE 9.1.1 results. #677

Merged
merged 16 commits into from
Oct 9, 2024
Merged

Conversation

baldimir
Copy link
Collaborator

@baldimir baldimir commented Oct 9, 2024

  • This PR adds results for a new vendor - IBM. IBM BAMOE contains a downstream build of Drools, therefore I used the Drools runner to produce the results and there is not a separate runner added.
  • This PR also refactors and updates the Drools runner a bit. It was not properly maintained for some time, so I tried to fix as many "code smells" as possible. I also encapsulated some parts of the runner to separate classes, so it is not just one big class.
  • I also updated the Drools version to 10.0.999-SNAPSHOT as the previous Drools version is more than a year old. The Drools 10 final version will be hopefully released soon in the Apache KIE community. It is already being voted on. When the 10 release is out, I will update the Drools runner to the final version. The current snapshot should provide us with better results for Drools in the optional Drools PR check.
  • This PR also updates the Drools runner to point to Apache as a vendor, instead of Red Hat. I discussed this with @tarilabs, he is ok with this change. So for the future, Red Hat in results will be updated to Apache, when there are the first Drools 10 final results.

The commits should be squashed when merging.

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, BAMOE! :D

@tarilabs
Copy link
Member

tarilabs commented Oct 9, 2024

Congratulations for having fresh results of the Drools open source project in the TCK !

@baldimir
Copy link
Collaborator Author

baldimir commented Oct 9, 2024

@tarilabs not yet :) This is only adding for IBM BAMOE. I will update Drools results for when 10 is released. However I wanted to have the runner ready for that, so I will update as soon as possible. Of course the PR check will run with the new latest snapshot now, if this is merged.

@baldimir
Copy link
Collaborator Author

baldimir commented Oct 9, 2024

Looks like I need to do some fixes for the Drools PR check now. I am working on it. I will push updates soon.

@baldimir
Copy link
Collaborator Author

baldimir commented Oct 9, 2024

Done.

@baldimir baldimir merged commit 3773cdf into dmn-tck:master Oct 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants