This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
can use provided DNANexus instance when compile-tool #19
Open
hurchu
wants to merge
27
commits into
dnanexus-archive:master
Choose a base branch
from
hurchu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Junfei, thanks for your PRs! I noticed you were updating the branch, so just let me know when you're ready and I'll review it to incorporate it as a part of the tool. Thanks again |
Hi Geet,
I've done some updates to support:
1. publish apps
2. build workflow with apps
3. add suggestions
4. try no use compile_inline_js_wf_input to build extra applets
I'm ready to create pull request from my master.
Best,
Junfei
…On Wed, Jan 31, 2018 at 5:03 PM, Geet Duggal ***@***.***> wrote:
Hi Junfei, thanks for your PRs! I noticed you were updating the branch, so
just let me know when you're ready and I'll review it to incorporate it as
a part of the tool. Thanks again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMnCpLXrozdAbp4hmukZ_-K6i6vAp5noks5tQPEsgaJpZM4Ryl0G>
.
--
Junfei Zhu
|
Hi Geet, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added one optional parameter dnanexus_instance.
When run compile-tool, we can provide the instance the user prefers.