Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo in the CONTRIBUTING document #40

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

amoghrajesh
Copy link
Contributor

Description

Fixing a typo in the CONTRIBUTING document.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests
    NA. Documentation change

Checklist:

  • My code has been linted (make lint)
    NA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
    NA
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    NA
  • New and existing unit tests pass locally with my changes
    NA
  • I have rebased my branch to include the latest changes from master

@ghost
Copy link

ghost commented Oct 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@amoghrajesh
Copy link
Contributor Author

@dnnrly can you review this? It is a simple doc fix, can you consider it for hacktoberfest?

Copy link
Owner

@dnnrly dnnrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dnnrly dnnrly merged commit 3294305 into dnnrly:master Oct 1, 2023
4 checks passed
@dnnrly
Copy link
Owner

dnnrly commented Oct 1, 2023

Don't worry, this is a hacktoberfest eligible project so the approval makes it count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants