-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop
into release/10.0.0
#5826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update bug-report.yml to include v9.13-rc
In order for projects to not require a full reference to the source generator project, the attribute cannot be defined in the project. The first attempt to resolve this was to generate the attribute via the source generator itself, but since the Library project exposes its internals to other projects (e.g. DotNetNuke.HttpModules), this resulted in ambiguous references. As a result, moving the type to a project that all other projects can reference seemed to be the best compromise. Since the attribute is conditional, it doesn't affect the public API of that project. Fixes #5815
Move DnnDeprecatedAttribute to Abstractions
fix: resourceManager copyUrl
resourceManager bad url using Azure
Shorten source generator test snapshot file names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a release management task, as per our policy, we are self-approving it.